[QEff Finetune]: Enable PP+DDP #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamta Singh <[email protected]>
quic-mamta
requested review from
quic-rishinr,
ochougul and
quic-amitraj
as code owners
quic-mamta
force-pushed
the
pp_ddp
branch
2 times, most recently
from
e8b1da7 to
df36ae1
Compare
quic-mamta
force-pushed
the
pp_ddp
branch
8 times, most recently
from
3ca1229 to
53ff3c4
Compare
quic-meetkuma
requested changes
May 12, 2025
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
quic-swatia
reviewed
Jun 2, 2025
Signed-off-by: Mamta Singh <[email protected]>
quic-mamta
force-pushed
the
pp_ddp
branch
3 times, most recently
from
92a4ec1 to
a67091a
Compare
quic-meetkuma
requested changes
Jul 14, 2025
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
quic-swatia
reviewed
Jul 16, 2025
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
quic-meetkuma
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Few comments are there but those are minor comments. See if they can be addressed in this PR. If not, then also it is fine, can be taken as later on. Overall looks good. Thanks for good amount of code cleanup and multiple experiments to validate the PP+DDP working, Mamta. :)
Signed-off-by: Mamta Singh <[email protected]>
quic-swatia
reviewed
Jul 18, 2025
quic-swatia
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for PP+DDP
Command for PP only : QAIC_VISIBLE_DEVICES=0,1,2,3 python -m QEfficient.cloud.finetune --device qaic --enable_pp --num_pp_stages 4 (number of pipeline stages must be less than or equal to total available devices)
Command for DDP only : QAIC_VISIBLE_DEVICES=0,1,2,3 torchrun --nproc_per_node 4 -m QEfficient.cloud.finetune --device qaic --enable_ddp
Command for PP+DDP : For 4 qaic devices(1 Ultra) with 2 pipeline stages
QAIC_VISIBLE_DEVICES=0,1,2,3 torchrun --nproc-per-node 2 -m QEfficient.cloud.finetune --device qaic --enable_ddp --enable_pp --num_pp_stages 2